PROCESS JSON COMMAND - New Features #3341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had this discussion before: Exceptions ( (and our homebrew platforms but they do not have JSON support enabled so you do not see them failing here) |
The Operations were updated to: 0: GET 1: SET 2: GET LENGTH 3: GET KEYS 4: GET VAR TYPE There are also new Flags: - Extract data from json path - similar to how stringvars extracts. - Prettify json - to make its output easier to read. Update json_helper.cpp
jetrotal
force-pushed
the
JSON-UPDATES
branch
from
e632a37 to
b1c6177
Compare
|
Sorry about the confusion, Now the code is way closer to how initially was |
|
I found some OOB crashes from the older implementation, "lists": {
"length": 5,
"data": [{
"id": "MAP TYPE",
"length": 7,
"values": ["EasyRPG World", "EasyRPG Exterior", "EasyRPG Interior", "EasyRPG Dungeon", "EasyRPG Ship", "Uncanny World", "Danny's House"],
"chipset_files": ["EasyRPG_World", "EasyRPG_Exterior", "easyRPG_interiorB", "EasyRPG_Dungeon", "EasyRPG_Ship", "EasyRPG+gfragger_mkt_CCBY", "EasyRPG+kotatsuAkira_Interior_CC0"],
"tileset_locations": [1531, 1535, 1534, 1533, 1532, 523, 524],
"current": 0
},
{
"id": "TILES LAYER",
"length": 3,
"values": ["LOWER", "UPPER", "EVENTS"],
"current": 0
},
{
"id": "DRAW AUTOTILES",
"length": 2,
"values": ["YES", "NO"],
"current": 0
},
{
"id": "MAP PANORAMA",
"length": 4,
"values": ["[OFF]", "A", "B", "C"],
"current": 0
},
{
"id": "BACKGROUND MUSIC",
"length": 4,
"values": ["[OFF]", "A", "B", "C"],
"current": 0
}
]
},I thought about adding some error messages, but those messages could conflict with cases such as: [
[-6,-6,-6,-6,-6,-6,-6,-6,-6,-6],
[6,-6,-6,null,-6,-6,-6],[-6,-6,-6,-6,-6,-6,-6,null,null,null,-6,-6],
[-6,6,-6,null,-6,-6,-6,-6,-6,-6,-6,-6],
[-6,6,6,null,14,14,14,-6,14,14,14,-6,14,14,14,null,14,14,14,6],
[6,6,6,null,null,14,6,null,14,null,null,null,14,-6,-6,-6,-6,14]
]where I wanted to have null values to fast walk through a list of map tiles. |
…lohmann::ordered_json this can break for loops, and it's a weird extra step when processing json data
…da functions to reduce repetition.
jetrotal
force-pushed
the
JSON-UPDATES
branch
from
5782f85 to
badd8c6
Compare
|
To fix (well, disable) nlohmann for Ubuntu 20.04 you must require a newer version of nlohmann. 3.9.1 appears to work. In CMakeLists: player_find_package(NAME nlohmann_json
VERSION 3.9.1
CONDITION PLAYER_WITH_NLOHMANN_JSON
DEFINITION HAVE_NLOHMANN_JSON
TARGET nlohmann_json::nlohmann_json
ONLY_CONFIG
)There are 2 cases where nlohmann_json is used in the file. Please add configure.ac: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Operations were updated to:
0: GET VALUE
1: SET VALUE
2: GET LENGTH
3: GET KEYS
4: GET VAR TYPE
5: REMOVE VALUE
6: PUSH INTO ARRAW
7: POP FROM ARRAY
8: CHECK IF VALUE EXISTS
There are also new Flags: