Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ONL-8270 Migrated dropdowns and other inputs to TS. #1861

Merged
merged 7 commits into from
Feb 16, 2024
Merged

[ONL-8270 Migrated dropdowns and other inputs to TS. #1861

merged 7 commits into from
Feb 16, 2024

Conversation

mcibique
Copy link
Contributor

@mcibique mcibique commented Feb 14, 2024 •
edited
Loading

Migrated:

  • EcDropdownSearch
  • EcDropdown
  • EcBtnDropdown
  • EcTextarea
  • EcAmountInput
  • EcPhoneNumberInput

Fixed:

  • ec-amount directive used by ec-amount-input not preserving options whole time. Added tests for this.
  • ec-datepicker occasionally crashing in integration tests because we try to reposition destroyed datepicker in C&P.

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chameleon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 0:20am

@mcibique mcibique marked this pull request as ready for review February 15, 2024 08:51
@mcibique mcibique requested a review from raulwwq0 February 15, 2024 08:51
@mcibique
Update src/components/ec-amount-input/ec-amount-input.vue
bcdbf1a 
Co-authored-by: Anton Lazarev <anton.lazarev@ebury.com>
@mcibique mcibique merged commit 897751e into master Feb 16, 2024
4 checks passed
@mcibique mcibique deleted the ONL-8270-migrate-dropdowns-and-inputs branch February 16, 2024 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wolandec wolandec wolandec approved these changes

@stavros-tomas stavros-tomas stavros-tomas approved these changes

@derrick-g derrick-g Awaiting requested review from derrick-g

@corinaper corinaper Awaiting requested review from corinaper corinaper is a code owner

@raulwwq0 raulwwq0 Awaiting requested review from raulwwq0 raulwwq0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcibique @wolandec @stavros-tomas