Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

deprecate HealthServicesRequest#tags in favor of filter #213

Open
ovesh opened this issue May 14, 2021 · 1 comment · May be fixed by #226
Open

deprecate HealthServicesRequest#tags in favor of filter #213

ovesh opened this issue May 14, 2021 · 1 comment · May be fixed by #226

Comments

@ovesh
Copy link

ovesh commented May 14, 2021 •
edited
Loading

Consul api docs say that the tag parameter for /health/service/:service is deprecated:

Use filter with the Service.Tags selector instead. This parameter will be removed in a future version of Consul.

Deprecate the tag related methods and add new filter methods instead (filter docs).
@ovesh
Copy link
Author

ovesh commented May 14, 2021

I'm working on a pr for this

@ovesh ovesh mentioned this issue May 18, 2021
Closed
@ovesh ovesh linked a pull request Oct 12, 2021 that will close this issue
Open
ovesh pushed a commit to indeedeng/consul-api that referenced this issue Oct 12, 2021
Merge branch 'Ecwidgh-213'
a808b38
ovesh added a commit to indeedeng/consul-api that referenced this issue Oct 21, 2021
@ovesh
Merge pull request #3 from indeedeng/Ecwidgh-213-indeed
a16c5e8 
url-encode filter parameter
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for the filter tag indeedeng/consul-api
1 participant
@ovesh