[ADMINAPI-975] Update packages for microsoft.data.sqlserver patch, increment minor version #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpat-adam
force-pushed
the
ADMINAPI-975
branch
from
e0adfa2 to
54aae1a
Compare
simpat-adam
force-pushed
the
ADMINAPI-975
branch
from
54aae1a to
899bfcb
Compare
stephenfuqua
reviewed
Feb 6, 2024
eng/connection-strings.psm1
Outdated
| } | ||
|
|
||
| return $connectionString + "User Id=$Username;Password=$Password" | ||
| return $connectionString + "User Id=$Username;Password=$Password;Encrypt=False;" |
There was a problem hiding this comment.
How is this connection string being used? Might be better to make this a user-generated parameter instead of hard-coding this value.
There was a problem hiding this comment.
Agree with @stephenfuqua. We have documentation. On Admin API 2.x installer we are accepting user parameter "UnEncryptedConnection" to take decision.
stephenfuqua
reviewed
Feb 7, 2024
...s.AdminApi/Infrastructure/Services/ClaimSetEditor/GetResourcesByClaimSetIdQueryV53Service.cs
Show resolved
Hide resolved
stephenfuqua
approved these changes
Feb 9, 2024
CSR2017
approved these changes
Feb 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.