Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ADMINAPI-766] Retrieve ODS API Version from appsettings #94

Merged
merged 6 commits into from
Jan 16, 2024
Merged

[ADMINAPI-766] Retrieve ODS API Version from appsettings #94

merged 6 commits into from
Jan 16, 2024

Conversation

simpat-adam
Copy link
Contributor

No description provided.

@simpat-adam simpat-adam force-pushed the ADMINAPI-766 branch 5 times, most recently from 96f4d4a to 193f7ff Compare January 12, 2024 14:20
@simpat-adam simpat-adam marked this pull request as ready for review January 12, 2024 15:36
jagudelo-gap
jagudelo-gap approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@jagudelo-gap jagudelo-gap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion. Use the new "switch" syntax in Application/EdFi.Ods.AdminApi/Infrastructure/OdsSecurityVersionResolver.cs

@CSR2017 CSR2017 merged commit e3294ca into main Jan 16, 2024
@CSR2017 CSR2017 deleted the ADMINAPI-766 branch January 16, 2024 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jagudelo-gap jagudelo-gap jagudelo-gap approved these changes

@CSR2017 CSR2017 CSR2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simpat-adam @CSR2017 @jagudelo-gap