Fix in-memory metadata stomping bug #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to setup a new metadata file in memory for the transaction if there doesn't already exists a file for the transaction. We only need to do this so that the state is present for other places in the core which depend on this state being present and deal with transaction state. In a future refactor, we can remove the setup entirely so long as we remove the dependency on this state always being present for transactions.
swansontec
approved these changes
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to setup a new metadata file in memory for the transaction
if there doesn't already exists a file for the transaction. We only need
to do this so that the state is present for other places in the core
which depend on this state being present and deal with transaction
state.
In a future refactor, we can remove the setup entirely so long as we
remove the dependency on this state always being present for
transactions.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none