Psalm - analyze errors in travis.ci

EdgedesignCZ · Sep 30, 2017 · 718e5fb · 718e5fb
1 parent 946d30e
commit 718e5fb
Show file tree

Hide file tree

Showing 5 changed files with 76 additions and 3 deletions.
diff --git a/bin/ci.sh b/bin/ci.sh
@@ -1,3 +1,3 @@
 #!/bin/sh
 
-./phpqa --verbose --report --config tests/.travis --tools phpcs:0,php-cs-fixer:0,phpmd:0,phpcpd:0,parallel-lint:0,phpstan:0,phpmetrics:0,phploc,pdepend,phpunit:0,psalm
+./phpqa --verbose --report --config tests/.travis --tools phpcs:0,php-cs-fixer:0,phpmd:0,phpcpd:0,parallel-lint:0,phpstan:0,phpmetrics:0,phploc,pdepend,phpunit:0,psalm:0
diff --git a/src/Config.php b/src/Config.php
@@ -24,7 +24,7 @@ private function loadConfig($directory, $isUserDirectory = false)
         $configDir = $directory . '/';
         $configFile = "{$configDir}.phpqa.yml";
         if (file_exists($configFile)) {
-            $config = Yaml::parse(file_get_contents($configFile));
+            $config = Yaml::parse((string) file_get_contents($configFile));
             $this->configs = array_merge(
                 array($configDir => $config),
                 $this->configs

diff --git a/src/Tools/GetVersions.php b/src/Tools/GetVersions.php
@@ -31,7 +31,7 @@ private function findComposerPackages()
             return [];
         }
 
-        $installedTools = json_decode(file_get_contents($installedJson));
+        $installedTools = json_decode((string) file_get_contents($installedJson));
         if (!is_array($installedTools)) {
             return [];
         }

diff --git a/tests/.travis/.phpqa.yml b/tests/.travis/.phpqa.yml
@@ -8,6 +8,10 @@ phpcs:
             info: phpcs-info.txt
             full: phpcs-full.txt
 
+psalm:
+    config: psalm.xml
+    deadCode: true
+
 phpstan:
     level: 7
     # https://github.com/phpstan/phpstan#configuration

diff --git a/tests/.travis/psalm.xml b/tests/.travis/psalm.xml
@@ -0,0 +1,69 @@
+<?xml version="1.0"?>
+<psalm
+    name="Example Psalm config with recommended defaults"
+    stopOnFirstError="false"
+    useDocblockTypes="true"
+    totallyTyped="false"
+>
+    <projectFiles>
+        <directory name="./" />
+        <ignoreFiles>
+            <directory name="vendor" />
+            <file name="src/Task/NonParallelExecV0.php" />
+            <file name="src/Task/NonParallelExecV1.php" />
+            <file name="src/Task/RoboAdapter.php" />
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <!-- phpqa specifics (compatibility classes, dynamic tools, ...) -->
+        <UnusedClass> 
+          <errorLevel type="info"> 
+            <directory name="tests" />
+            <directory name="src/Tools/Analyzer" />
+          </errorLevel> 
+        </UnusedClass> 
+        <UndefinedClass>
+          <errorLevel type="info">
+            <file name="src/Tools/Analyzer/Phpcs.php" />
+            <file name="src/Tools/Analyzer/PhpcsV3.php" />
+          </errorLevel>
+        </UndefinedClass>
+        <PossiblyUnusedMethod>
+          <errorLevel type="info">
+            <file name="src/CodeAnalysisTasks.php" />
+            <file name="src/Tools/Tool.php" />
+            <file name="src/RunningTool.php" />
+          </errorLevel>
+          <errorLevel type="suppress"> 
+            <directory name="tests" />
+          </errorLevel> 
+        </PossiblyUnusedMethod>
+        <DeprecatedMethod errorLevel="info" /> 
+
+        <!-- Ignored rules -->
+        <PropertyNotSetInConstructor errorLevel="info" />
+        <UndefinedConstant errorLevel="info" />
+        <MissingReturnType errorLevel="suppress" />
+        <MissingPropertyType errorLevel="suppress" />
+        <MissingClosureReturnType errorLevel="suppress" />
+        <MissingPropertyDeclaration errorLevel="suppress" />
+        <UntypedParam errorLevel="suppress" />
+
+        <!-- false positive -->
+        <UnusedVariable errorLevel="info" />
+        <PossiblyUnusedVariable errorLevel="info" />
+        <UndefinedThisPropertyAssignment errorLevel="info" />
+        <TooFewArguments> 
+          <errorLevel type="info"> 
+            <file name="src/report.php" /><!-- Too few arguments for method XSLTProcessor::setparameter --> 
+          </errorLevel> 
+        </TooFewArguments> 
+        <TooManyArguments> 
+          <errorLevel type="suppress"> 
+            <directory name="tests" /><!-- Too many arguments for method assertthat --> 
+          </errorLevel> 
+        </TooManyArguments>
+
+    </issueHandlers>
+</psalm>