Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pass the "--names" option to PHPCPD. #192

Closed
wants to merge 2 commits into from

Conversation

beerendlauwers
Copy link

Addresses #170.

@zdenekdrahos
Copy link
Member

zdenekdrahos commented Dec 3, 2019

It might be better to use phpqa.extensions just like in the other tools. The extensions are already documented and you don't have to define extensions twice. What do you think?

$phpcpdNames = array_map(
    function ($extension) {
        return "*.{$extension}";
    },
    explode(',', $this->config->csv('phpqa.extensions'))
);
// ...
names' => implode(',', $phpcpdNames),

@beerendlauwers
Copy link
Author

Good point. Refactored.

Co-Authored-By: Zdeněk Drahoš <drahoszdenek@gmail.com>
@zdenekdrahos
Copy link
Member

Fixed in #193

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants