Skip to content

Commit c74c7e8

Browse files
josephsavonaAndyPengc12
authored andcommitted
[be] Remove unshipped experimental <Cache> element type (facebook#28698)
Removes the `<Cache />` element type since we're going with a simpler caching strategy.
1 parent 1099242 commit c74c7e8

19 files changed

+0
-1643
lines changed

packages/react-devtools-shared/src/__tests__/store-test.js

-2
Original file line numberDiff line numberDiff line change
@@ -1575,7 +1575,6 @@ describe('Store', () => {
15751575
<FakeHigherOrderComponent />
15761576
<MemoizedFakeHigherOrderComponent />
15771577
<ForwardRefFakeHigherOrderComponent />
1578-
<React.unstable_Cache />
15791578
<MemoizedFakeHigherOrderComponentWithDisplayNameOverride />
15801579
<ForwardRefFakeHigherOrderComponentWithDisplayNameOverride />
15811580
</React.Fragment>
@@ -1603,7 +1602,6 @@ describe('Store', () => {
16031602
<Baz> [withFoo][withBar]
16041603
<Baz> [Memo][withFoo][withBar]
16051604
<Baz> [ForwardRef][withFoo][withBar]
1606-
<Cache>
16071605
<memoRefOverride>
16081606
<forwardRefOverride>
16091607
`);

packages/react-devtools-shell/src/app/ElementTypes/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {
1818
Profiler,
1919
StrictMode,
2020
Suspense,
21-
unstable_Cache as Cache,
2221
} from 'react';
2322

2423
const Context = createContext('abc');

packages/react-reconciler/src/ReactFiber.js

-20
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import {
2828
isHostSingletonType,
2929
} from './ReactFiberConfig';
3030
import {
31-
enableCache,
3231
enableProfilerTimer,
3332
enableScopeAPI,
3433
enableLegacyHidden,
@@ -66,7 +65,6 @@ import {
6665
ScopeComponent,
6766
OffscreenComponent,
6867
LegacyHiddenComponent,
69-
CacheComponent,
7068
TracingMarkerComponent,
7169
} from './ReactWorkTags';
7270
import {OffscreenVisible} from './ReactFiberActivityComponent';
@@ -104,7 +102,6 @@ import {
104102
REACT_SCOPE_TYPE,
105103
REACT_OFFSCREEN_TYPE,
106104
REACT_LEGACY_HIDDEN_TYPE,
107-
REACT_CACHE_TYPE,
108105
REACT_TRACING_MARKER_TYPE,
109106
} from 'shared/ReactSymbols';
110107
import {TransitionTracingMarker} from './ReactFiberTracingMarkerComponent';
@@ -560,11 +557,6 @@ export function createFiberFromTypeAndProps(
560557
return createFiberFromScope(type, pendingProps, mode, lanes, key);
561558
}
562559
// Fall through
563-
case REACT_CACHE_TYPE:
564-
if (enableCache) {
565-
return createFiberFromCache(pendingProps, mode, lanes, key);
566-
}
567-
// Fall through
568560
case REACT_TRACING_MARKER_TYPE:
569561
if (enableTransitionTracing) {
570562
return createFiberFromTracingMarker(pendingProps, mode, lanes, key);
@@ -807,18 +799,6 @@ export function createFiberFromLegacyHidden(
807799
return fiber;
808800
}
809801

810-
export function createFiberFromCache(
811-
pendingProps: any,
812-
mode: TypeOfMode,
813-
lanes: Lanes,
814-
key: null | string,
815-
): Fiber {
816-
const fiber = createFiber(CacheComponent, pendingProps, key, mode);
817-
fiber.elementType = REACT_CACHE_TYPE;
818-
fiber.lanes = lanes;
819-
return fiber;
820-
}
821-
822802
export function createFiberFromTracingMarker(
823803
pendingProps: any,
824804
mode: TypeOfMode,

0 commit comments

Comments
 (0)