Skip to content

[be] Remove unshipped experimental <Cache> element type #28698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

josephsavona
Copy link
Contributor

Removes the <Cache /> element type since we're going with a simpler caching strategy.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 1, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024

Comparing: 95e6f03...3d16070

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 176.97 kB = 55.05 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.94 kB 172.83 kB = 53.91 kB 53.88 kB
facebook-www/ReactDOM-prod.classic.js = 592.68 kB 592.36 kB = 103.96 kB 103.92 kB
facebook-www/ReactDOM-prod.modern.js = 574.37 kB 574.10 kB = 100.98 kB 100.96 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react/cjs/react.react-server.development.js = 76.78 kB 76.61 kB = 21.29 kB 21.25 kB
oss-stable-semver/react/cjs/react.react-server.development.js = 76.76 kB 76.58 kB = 21.26 kB 21.22 kB
oss-experimental/react/cjs/react.production.js = 41.55 kB 41.46 kB = 11.44 kB 11.42 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 50.70 kB 50.54 kB = 13.27 kB 13.24 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 50.70 kB 50.54 kB = 13.27 kB 13.24 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 49.79 kB 49.63 kB = 13.15 kB 13.12 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 48.38 kB 48.22 kB = 12.79 kB 12.76 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 42.77 kB 42.62 kB = 12.85 kB 12.82 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 42.70 kB 42.55 kB = 12.83 kB 12.79 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 41.47 kB 41.32 kB = 12.49 kB 12.45 kB
oss-experimental/react/umd/react.production.min.js = 13.49 kB 13.44 kB = 5.12 kB 5.12 kB
oss-experimental/react/umd/react.profiling.min.js = 13.49 kB 13.44 kB = 5.12 kB 5.12 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js = 42.37 kB 42.20 kB = 12.53 kB 12.50 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js = 42.37 kB 42.20 kB = 12.53 kB 12.50 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 42.30 kB 42.13 kB = 12.51 kB 12.47 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 42.30 kB 42.13 kB = 12.51 kB 12.47 kB
facebook-www/React-profiling.classic.js = 21.92 kB 21.83 kB = 5.46 kB 5.43 kB
facebook-www/React-profiling.modern.js = 21.79 kB 21.70 kB = 5.43 kB 5.40 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 41.07 kB 40.90 kB = 12.16 kB 12.12 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 41.07 kB 40.90 kB = 12.16 kB 12.12 kB
facebook-www/React-prod.classic.js = 21.48 kB 21.39 kB = 5.37 kB 5.35 kB
facebook-react-native/react/cjs/React-profiling.js = 21.43 kB 21.34 kB = 5.36 kB 5.34 kB
facebook-www/React-prod.modern.js = 21.36 kB 21.26 kB = 5.34 kB 5.33 kB
facebook-react-native/react/cjs/React-prod.js = 21.12 kB 21.03 kB = 5.31 kB 5.29 kB
oss-experimental/react/cjs/react.production.min.js = 9.95 kB 9.89 kB = 3.67 kB 3.65 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.69 kB = 5.40 kB 5.38 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.69 kB = 5.40 kB 5.38 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.69 kB = 5.40 kB 5.38 kB
oss-stable-semver/react-is/umd/react-is.development.js = 8.03 kB 7.97 kB = 2.08 kB 2.06 kB
oss-stable/react-is/umd/react-is.development.js = 8.03 kB 7.97 kB = 2.08 kB 2.06 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.43 kB 7.37 kB = 1.98 kB 1.97 kB
oss-stable/react-is/cjs/react-is.development.js = 7.43 kB 7.37 kB = 1.98 kB 1.97 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 7.42 kB 7.36 kB = 1.94 kB 1.93 kB
oss-stable/react-is/cjs/react-is.production.js = 7.42 kB 7.36 kB = 1.94 kB 1.93 kB
oss-experimental/react-is/umd/react-is.development.js = 8.05 kB 7.97 kB = 2.08 kB 2.06 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.45 kB 7.37 kB = 1.99 kB 1.97 kB
oss-experimental/react-is/cjs/react-is.production.js = 7.44 kB 7.36 kB = 1.95 kB 1.93 kB
facebook-www/ReactIs-dev.classic.js = 8.30 kB 8.20 kB = 1.97 kB 1.95 kB
facebook-www/ReactIs-dev.modern.js = 8.29 kB 8.20 kB = 1.97 kB 1.95 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 8.15 kB 8.06 kB = 2.03 kB 2.02 kB
facebook-www/ReactIs-prod.classic.js = 5.83 kB 5.75 kB = 1.36 kB 1.35 kB
facebook-www/ReactIs-prod.modern.js = 5.83 kB 5.75 kB = 1.36 kB 1.35 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 5.27 kB 5.19 kB = 1.28 kB 1.26 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 5.27 kB 5.19 kB = 1.28 kB 1.26 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.31 kB 2.27 kB = 0.87 kB 0.85 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.24 kB 2.20 kB = 0.78 kB 0.78 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 3d16070

@josephsavona josephsavona merged commit 7319c61 into facebook:main Apr 2, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Removes the `<Cache />` element type since we're going with a simpler
caching strategy.

DiffTrain build for [7319c61](7319c61)
josephsavona added a commit that referenced this pull request Apr 2, 2024
josephsavona added a commit that referenced this pull request Apr 2, 2024
Similar to #28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Similar to #28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.

DiffTrain build for [8cb6a1c](8cb6a1c)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Removes the `<Cache />` element type since we're going with a simpler
caching strategy.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Similar to facebook#28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.
hoxyq added a commit that referenced this pull request Apr 15, 2024
Full list of changes:
* Look for a ReactMemoCacheSentinel on state
([gsathya](https://github.com/gsathya) in
[#28831](#28831))
* Use use() in the Cache if available
([sebmarkbage](https://github.com/sebmarkbage) in
[#28793](#28793))
* feat[devtools-fusebox]: support theme option
([hoxyq](https://github.com/hoxyq) in
[#28832](#28832))
* feat[devtools]: add package for fusebox integration
([hoxyq](https://github.com/hoxyq) in
[#28553](#28553))
* feat[devtools]: add method for connecting backend with custom
messaging protocol ([hoxyq](https://github.com/hoxyq) in
[#28552](#28552))
* Rename SECRET INTERNALS to
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
([sebmarkbage](https://github.com/sebmarkbage) in
[#28789](#28789))
* Flatten ReactSharedInternals
([sebmarkbage](https://github.com/sebmarkbage) in
[#28783](#28783))
* feat[devtools]: ship source maps for content scripts and ignore list
installHook script ([hoxyq](https://github.com/hoxyq) in
[#28730](#28730))
* Track Owner for Server Components in DEV
([sebmarkbage](https://github.com/sebmarkbage) in
[#28753](#28753))
* Move ReactDOMLegacy implementation into RootFB
([sebmarkbage](https://github.com/sebmarkbage) in
[#28656](#28656))
* Reland #28672: Remove IndeterminateComponent
([gnoff](https://github.com/gnoff) in
[#28681](#28681))
* Remove reference to deleted <Cache> in un-linted file
([josephsavona](https://github.com/josephsavona) in
[#28715](#28715))
* [be] Remove unshipped experimental <Cache> element type
([josephsavona](https://github.com/josephsavona) in
[#28698](#28698))
* Revert "Remove module pattern function component support"
([rickhanlonii](https://github.com/rickhanlonii) in
[#28670](#28670))
* Remove module pattern function component support
([gnoff](https://github.com/gnoff) in
[#27742](#27742))
* [RTR] Enable warning flag ([jackpope](https://github.com/jackpope) in
[#28419](#28419))
* Update error messages ([rickhanlonii](https://github.com/rickhanlonii)
in [#28652](#28652))
* fix[devtools/ci]: split profiling cache test for different react
versions and toEqual checker ([hoxyq](https://github.com/hoxyq) in
[#28628](#28628))
* Guard against legacy context not being supported in DevTools fixture
([eps1lon](https://github.com/eps1lon) in
[#28596](#28596))
* Use `declare const` instead of `declare var`
([kassens](https://github.com/kassens) in
[#28599](#28599))
* Update isConcurrent RTR option usage
([jackpope](https://github.com/jackpope) in
[#28546](#28546))
* Disable legacy context ([kassens](https://github.com/kassens) in
[#27991](#27991))
* Remove invokeGuardedCallback and replay trick
([sebmarkbage](https://github.com/sebmarkbage) in
[#28515](#28515))
* Remove remaining usages of ReactTestUtils in tests unrelated to
`react-dom/test-util` ([eps1lon](https://github.com/eps1lon) in
[#28534](#28534))
* fix[devtools/e2e]: fixed source inspection in e2e tests
([hoxyq](https://github.com/hoxyq) in
[#28518](#28518))
* Devtools: Display actual pending state when inspecting `useTransition`
([eps1lon](https://github.com/eps1lon) in
[#28499](#28499))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Removes the `<Cache />` element type since we're going with a simpler
caching strategy.

DiffTrain build for commit 7319c61.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Similar to #28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.

DiffTrain build for commit 8cb6a1c.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants