Prevent Effect.if from crashing when first argument is not an Effect (#…

…2299) Co-authored-by: Tim <hello@timsmart.co> Co-authored-by: Michael Arnaldi <michael.arnaldi@effectful.co>
Effect-TS · Mar 16, 2024 · 814e5b8 · 814e5b8
1 parent 6b20bad
commit 814e5b8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/wicked-apples-press.md b/.changeset/wicked-apples-press.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Prevent Effect.if from crashing when first argument is not an Effect
diff --git a/packages/effect/src/internal/core.ts b/packages/effect/src/internal/core.ts
@@ -952,7 +952,8 @@ export const if_ = dual<
   (self: boolean | Effect.Effect<unknown, unknown, unknown>, { onFalse, onTrue }: {
     readonly onTrue: Effect.Effect<unknown, unknown, unknown>
     readonly onFalse: Effect.Effect<unknown, unknown, unknown>
-  }) => typeof self === "boolean" ? (self ? onTrue : onFalse) : flatMap(self, (b) => (b ? onTrue : onFalse))
+    // eslint-disable-next-line no-extra-boolean-cast
+  }) => isEffect(self) ? flatMap(self, (b) => (b ? onTrue : onFalse)) : Boolean(self) ? onTrue : onFalse
 )
 
 /* @internal */