Support Refinement in Preficate.tuple and Predicate.struct
#3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add line to doc rollback or dtslint tests return test fix changelog fix type PR fixes support combination predicates and refinements
🦋 Changeset detectedLatest commit: 012e62f The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
github-actions
bot
force-pushed
the
next-minor
branch
from
7854b34 to
ca11e3b
Compare
tim-smart
reviewed
Jul 28, 2024
packages/effect/src/Predicate.ts
Outdated
| export const tuple: { | ||
| <T extends ReadonlyArray<Predicate.Any>>( | ||
| ...elements: T | ||
| ): true extends { [K in keyof T]: T[K] extends Refinement.Any ? true : false }[number] ? Refinement< |
There was a problem hiding this comment.
Would this be better? Then you can remove the intermediate record:
[Extract<A[keyof A], Predicate.Refinement<any, any>>] extends [never]There was a problem hiding this comment.
Yes, It works and more elegant.
packages/effect/src/Predicate.ts
Outdated
| <T extends ReadonlyArray<Predicate.Any>>( | ||
| ...elements: T | ||
| ): true extends { [K in keyof T]: T[K] extends Refinement.Any ? true : false }[number] ? Refinement< | ||
| Readonly<{ [I in keyof T]: T[I] extends Refinement.Any ? Refinement.In<T[I]> : Predicate.In<T[I]> }>, |
There was a problem hiding this comment.
Suggested change
| Readonly<{ [I in keyof T]: T[I] extends Refinement.Any ? Refinement.In<T[I]> : Predicate.In<T[I]> }>, | |
| { readonly [I in keyof T]: T[I] extends Refinement.Any ? Refinement.In<T[I]> : Predicate.In<T[I]> }, |
You can do it in one pass.
github-actions
bot
force-pushed
the
next-minor
branch
4 times, most recently
from
7518908 to
48af068
Compare
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
tim-smart
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
tim-smart
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
Merged
tim-smart
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support combination predicates and refinements
Type
Description
Related