[SmartSkip]: Use pure-lua-hash. #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral seconds (can be up to 1x secs) on the first run, and an average of 300-ms on subsequent runs
|
Ah I know how we can approach it without forcing users to download the module. Basically, we can make it optional, if the user has the script-module then it will use pure lua, otherwise, it fall backs to powershell. Can you do this modification? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, powershell hash takes several seconds (can be up to 1x secs) on the first run, and an average of 300-ms on subsequent runs. Pure lua hash takes only 1-ms even on first run. #151