forked from Zerocash/libzerocash
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Pour symmetry and variable input coin arity #19
Closed
ebfull
wants to merge
16
commits into
zc.latest.0
from
zc.latest.0.ticket456-add-symmetry-to-circuit.1
Closed
Add Pour symmetry and variable input coin arity #19
ebfull
wants to merge
16
commits into
zc.latest.0
from
zc.latest.0.ticket456-add-symmetry-to-circuit.1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthentication for zero-value input coins.
* Add new `PourInput` and `PourOutput` interfaces. * Make the pour module optionally return pours if they fail satisfaction checks.
Impact on the circuit is negligible:
Note: This is for the test depth of 4. |
Where can one find the new circuit description; in particular, the explicit inputs, implicit ones, and the circuit's logic (high level description)? It would be good to maintain in some place such an updated description (if none exists yet) |
@elibensasson It's awesome that you ask. :) That's something I'm working on. I've filed a ticket for that. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pour symmetry is our (informal) name for adding a
vpub_in
to the balance equation to make it possible to pass value in and out of pours with more flexibility. In order to makePour
s completely replaceProtect
s, there must also be variable input arity. (AProtect
-stylePour
has zero inputs.)This PR makes a number of changes to the circuit to accomodate this design change:
vpub_in
is provided for the balance equation as a verifier input.In order to fully support this new design, I've added
PourInput
andPourOutput
classes to abstract away these concepts as they will (in some transactions) be omitted. I've made the appropriate changes toPourTransaction
. (Hopefully, in the future we can abandon the old API design entirely, but I've left it for legacy purposes.)