Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dark mode QR codes for Receive screen #1473

Closed
HonzaR opened this issue Jun 17, 2024 · 0 comments · Fixed by #1724
Closed

Dark mode QR codes for Receive screen #1473

HonzaR opened this issue Jun 17, 2024 · 0 comments · Fixed by #1724

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented Jun 17, 2024

Is your feature request related to a problem? Please describe.

As a follow-up for #1011 we'd like to introduce dark mode QR codes to improve dark mode UX.

Describe the solution you'd like

The color change is easily achievable using the implemented screen.receive.util.AndroidQrCodeImageGeneratorKt#toBlackAndWhiteColorArray

However, such a QR code is not readable with our QR code scan logic.

So, the task here is to improve the generated QR code or scan logic to be compatible. The compatibility needs to be ensured in cross-platform and cross-apps ways.

Alternatives you've considered

Additional context

HonzaR added a commit that referenced this issue Jan 9, 2025
- Closes #1473
- These changes add dark theme QR codes to `QrCodeView` and `RequestQrCodeVew` for all use cases
@HonzaR HonzaR mentioned this issue Jan 9, 2025
13 tasks
@HonzaR HonzaR closed this as completed in 37a7a1e Jan 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant