Update deploy.yml #1683
Open
Update deploy.yml #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonzaR
requested changes
Nov 15, 2024
daira
reviewed
Nov 20, 2024
Comment on lines
+112
to
+113
| echo $FIREBASE_DEBUG_JSON_BASE64 | base64 --decode > app/src/debug/google-services.json | ||
| echo $FIREBASE_RELEASE_JSON_BASE64 | base64 --decode > app/src/release/google-services.json |
There was a problem hiding this comment.
Suggested change
| echo $FIREBASE_DEBUG_JSON_BASE64 | base64 --decode > app/src/debug/google-services.json | |
| echo $FIREBASE_RELEASE_JSON_BASE64 | base64 --decode > app/src/release/google-services.json | |
| echo "$FIREBASE_DEBUG_JSON_BASE64" | base64 --decode > app/src/debug/google-services.json | |
| echo "$FIREBASE_RELEASE_JSON_BASE64" | base64 --decode > app/src/release/google-services.json |
There was a problem hiding this comment.
Also double-quote $GITHUB_OUTPUT on line 72.
daira
reviewed
Nov 20, 2024
| - name: Export Google Services JSON | ||
| env: | ||
| FIREBASE_DEBUG_JSON_BASE64: ${{ secrets.FIREBASE_DEBUG_JSON_BASE64 }} | ||
| FIREBASE_RELEASE_JSON_BASE64: ${{ secrets.FIREBASE_RELEASE_JSON_BASE64 }} | ||
| if: "${{ env.FIREBASE_DEBUG_JSON_BASE64 != '' && env.FIREBASE_RELEASE_JSON_BASE64 != '' }}" | ||
| shell: bash | ||
| if: ${{ env.FIREBASE_DEBUG_JSON_BASE64 != '' && env.FIREBASE_RELEASE_JSON_BASE64 != '' }} |
There was a problem hiding this comment.
If the syntax with double quotes around a GitHub Actions expression causes a problem, note that it also occurs on lines 67-71. (You can omit the ${{ and }} when used with if:, btw.)
daira
reviewed
Nov 20, 2024
| run: | | ||
| echo ${SIGNING_KEYSTORE_BASE_64} | base64 --decode > ${SIGNING_KEY_PATH} | ||
| echo $SIGNING_KEYSTORE_BASE_64 | base64 --decode > $SIGNING_KEY_PATH |
There was a problem hiding this comment.
Suggested change
| echo $SIGNING_KEYSTORE_BASE_64 | base64 --decode > $SIGNING_KEY_PATH | |
| echo "$SIGNING_KEYSTORE_BASE_64" | base64 --decode > "$SIGNING_KEY_PATH" |
daira
reviewed
Nov 20, 2024
Comment on lines
+149
to
+151
| mkdir $ARTIFACTS_DIR_PATH | ||
| zip -r $BINARIES_ZIP_PATH . -i app/build/outputs/apk/*/*.apk app/build/outputs/apk_from_bundle/*/*.apk app/build/outputs/bundle/*/*.aab | ||
| zip -r $MAPPINGS_ZIP_PATH . -i app/build/outputs/mapping/*/mapping.txt |
There was a problem hiding this comment.
Suggested change
| mkdir $ARTIFACTS_DIR_PATH | |
| zip -r $BINARIES_ZIP_PATH . -i app/build/outputs/apk/*/*.apk app/build/outputs/apk_from_bundle/*/*.apk app/build/outputs/bundle/*/*.aab | |
| zip -r $MAPPINGS_ZIP_PATH . -i app/build/outputs/mapping/*/mapping.txt | |
| mkdir "$ARTIFACTS_DIR_PATH" | |
| zip -r "$BINARIES_ZIP_PATH" . -i app/build/outputs/apk/*/*.apk app/build/outputs/apk_from_bundle/*/*.apk app/build/outputs/bundle/*/*.aab | |
| zip -r "$MAPPINGS_ZIP_PATH" . -i app/build/outputs/mapping/*/mapping.txt |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing CI