Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose ZIP 317 #1204

Closed
LukasKorba opened this issue Aug 18, 2023 · 2 comments
Closed

Expose ZIP 317 #1204

LukasKorba opened this issue Aug 18, 2023 · 2 comments
Labels
C-target Category: This is a high-level target that forms the root of a sub-graph in the DAG.
Milestone

Comments

@LukasKorba
Copy link
Collaborator

No description provided.

LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this issue Aug 18, 2023
- the flag can be turned on/off via new public API
- changelog updated
- unit tests for the toggle added
@LukasKorba LukasKorba mentioned this issue Aug 18, 2023
14 tasks
@nuttycom nuttycom added this to the ZIP 317 in Mobile SDKs milestone Jan 2, 2024
@str4d str4d added the C-target Category: This is a high-level target that forms the root of a sub-graph in the DAG. label Feb 6, 2024
@nuttycom nuttycom modified the milestones: ZIP 317 in Mobile SDKs, iOS Zashi 1.0 Feb 9, 2024
@str4d
Copy link
Collaborator

str4d commented Feb 15, 2024

On the Android side (Electric-Coin-Company/zcash-android-wallet-sdk#1359), I'm working on creating new public SDK APIs that expose the proposal state (from which the total required fee will be accessible). Once the PR for that is ready, I'll attempt to replicate it in this SDK.

@str4d str4d added the S-in-progress Status: Work is currently in progress on this item. label Feb 20, 2024
str4d added a commit that referenced this issue Feb 21, 2024
str4d added a commit that referenced this issue Feb 21, 2024
@str4d str4d added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-in-progress Status: Work is currently in progress on this item. labels Feb 21, 2024
str4d added a commit that referenced this issue Feb 22, 2024
str4d added a commit that referenced this issue Feb 27, 2024
str4d added a commit that referenced this issue Feb 27, 2024
@str4d
Copy link
Collaborator

str4d commented Feb 27, 2024

In a pairing today, @nuttycom and I decided that we will change Synchronizer.proposeShielding in three ways:

  • It will take an optional transparent receiver, corresponding to a specific diversified UA (or the default transparent address) that should have its transparent funds shielded.
    • If the transparent receiver is not part of the specified account, an error will be returned.
    • If no receiver is provided, the current behaviour of "shield transparent funds in whichever transparent receiver under the account has them" will be used.
  • It will return an error if there are transparent funds in more than one transparent receiver in the given account.
    • This fixes an address linkability problem that currently exists with Synchronizer.shieldFunds, wherein a transaction spending funds from multiple transparent receivers in the same account can be created which indelibly links them on-chain.
    • We are not fixing the problem in Synchronizer.shieldFunds because working around it would require changing the shieldFunds API, but we are deprecating and soon removing the method instead.
  • It will return nil if there are no funds to shield (i.e. its proposal will be "do nothing"), a la zcash_client_backend: Change propose_shielding to return Option<Proposal> zcash/librustzcash#1200.

The transparent receiver argument serves two functions:

pacu pushed a commit to pacu/zcash-swift-wallet-sdk that referenced this issue Feb 29, 2024
@str4d str4d closed this as completed in 8145248 Mar 8, 2024
@true-jared true-jared removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-target Category: This is a high-level target that forms the root of a sub-graph in the DAG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants