Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove derivation of t-address from pubkey #512

Closed
pacu opened this issue Aug 29, 2022 · 0 comments · Fixed by #499
Closed

Remove derivation of t-address from pubkey #512

pacu opened this issue Aug 29, 2022 · 0 comments · Fixed by #499

Comments

@pacu
Copy link
Contributor

pacu commented Aug 29, 2022

#491 (comment)

We need to think carefully about this method, and whether it should continue to exist. It's not clear here whether the pubkey is the account pubkey or the child ("diversified") pubkey. I think my recommendation is that we get rid of transparent and Sapling derivation methods entirely, and make all access to these kinds of legacy addresses route through the unified address derivation system: basically, derive a unified address, then extract the component you want.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant