Warn about unused PROPKA options #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2023 10:59
Warn that we ignore some PROPKA options.
Replace values instead of removing attributes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 65.39% 65.40%
=======================================
Files 30 30
Lines 7789 7796 +7
=======================================
+ Hits 5094 5099 +5
- Misses 2695 2697 +2
☔ View full report in Codecov by Sentry. |
orbeckst
approved these changes
Jul 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365 .