Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Sphinx versions. #385

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update Sphinx versions. #385

merged 1 commit into from
Jan 16, 2024

Conversation

sobolevnrm
Copy link
Member

Fixes #384.

@sobolevnrm sobolevnrm self-assigned this Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd36b30) 66.35% compared to head (f44d38f) 66.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files          30       30           
  Lines        7796     7796           
=======================================
  Hits         5173     5173           
  Misses       2623     2623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I assume the docs build correctly.

(I am not a big fan of pinning to exact versions but I understand that getting the docs to build can be finicky and that having exact versions helps keeping the docs lower maintenance.)

@sobolevnrm sobolevnrm merged commit d75649f into master Jan 16, 2024
7 checks passed
@sobolevnrm sobolevnrm deleted the nathan/384 branch January 16, 2024 14:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Sphinx packages
2 participants