Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding tutorial docs for DataParallel, ZeroOptimizer #170

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

jinwonkim93
Copy link
Member

@jinwonkim93 jinwonkim93 commented Mar 29, 2023

Title

  • Add tutorial docs for DataParallel, ZeroOptimizer.

Description

Linked Issues

  • resolved #00

model = model.to("cuda")
# create optimizer
optimizer = ZeroRedundancyOptimizer(
Adam(model.parameters(), lr=3e-5),
Copy link
Member

@hyunwoongko hyunwoongko Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinwonkim93 @nijkah @KKIEEK @yhna940
How about using initializer parameters like model parameters, lr, optimizer class separately like this?

optimizer = ZeroOptimizer(
    optimizer_class=Adam,
    params=model.parameters(),
    lr=3e-5,
    weight_decay=5e-7,
    ... (other params) ...
)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to separate them?

@hyunwoongko
Copy link
Member

hyunwoongko commented Apr 13, 2023

@jinwonkim93 작업 끝나시면 말씀해주세요!

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2023

CLA assistant check
All committers have signed the CLA.

@jinwonkim93
Copy link
Member Author

@jinwonkim93 작업 끝나시면 말씀해주세요!

보내드린거 확인 부탁드려요~

@jinwonkim93 jinwonkim93 changed the title [WIP] adding tutorial for dp adding tutorial docs for DataParallel, ZeroOptimizer May 11, 2023
@hyunwoongko hyunwoongko marked this pull request as ready for review May 11, 2023 12:12
@hyunwoongko hyunwoongko merged commit 001ffec into main May 11, 2023
dyanos pushed a commit that referenced this pull request Jun 8, 2023
## Title

- Add tutorial docs for DataParallel, ZeroOptimizer.

## Description

-

## Linked Issues

- resolved #00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants