This repository was archived by the owner on Oct 28, 2023. It is now read-only.
Fix undefined behavior in Generator::update
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet. Also don't forget to add an ittem in the unreleased section of the changelog (can link the PR there also). |
MaikKlein
reviewed
Sep 18, 2019
MaikKlein
reviewed
Sep 18, 2019
Jake-Shadle
approved these changes
Sep 18, 2019
MaikKlein
approved these changes
Sep 18, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background info in #35.
This opts to keep the unsafe mutation of the two
Vec<T>ors and oneRgbaImage, but wraps those in semi-safe wrappers, only allowing limited mutation, and usingUnsafeCellunder the hood.Fixes #35