use crc32fast dependency #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like many parts of the codebase this is 100% stolen from codetheweb's implementation. But you are right. Using existing implementations is always preferrable. I think i will have time to merge this in the weekend. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that you implemented the CRC-32 algorithm yourself in your project, and it is mentioned that it is a customized version for Tuya devices. However, I observed that the implementation does not seem to differ from the one in the crc32fast library. I might be wrong, but the tests all seem to pass, and it works well to control my Tuya device. I think it would be better to use a widely adopted library here.
Best regards.