Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged changes to my fork. #11

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Conversation

Icelain
Copy link
Contributor

@Icelain Icelain commented Oct 16, 2020

Everything seems to be working now.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #11 into master will decrease coverage by 0.89%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   98.93%   98.03%   -0.90%     
==========================================
  Files           3        3              
  Lines          94      102       +8     
==========================================
+ Hits           93      100       +7     
- Misses          1        2       +1     
Impacted Files Coverage Δ
pyanchor/link_checker.py 97.77% <88.88%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f408d7...adb99e8. Read the comment docs.

@EndlessTrax EndlessTrax merged commit 21eb6a8 into EndlessTrax:master Oct 16, 2020
@EndlessTrax
Copy link
Owner

Thank you for your contribution. Appreciate your hard work.

For next time, you shouldn't need to create a new PR with each change. You should be able to just create on PR then add commits to it. Don't worry for now, doesn't matter so much on this small project, but if you create a PR on a larger project, that will be the expected practice.

Thanks again!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants