Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[encoding] Convert doc comment and fix doctest of SpecificCharacterSet::from_code #223

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Feb 23, 2022

This doctest was being ignored due to a regression in the compiler (rust-lang/rust#92872, rust-lang/rust#93038). It was only when the fix hit beta (v1.60) that it was identified that the test was missing an import.

I also looked for other doctests within block comments, but nothing more to report. One might as well default to line-based comments in the future and prefer not writing doc-tests inside block quotes.

- doctest was being ignored until v1.60
@Enet4 Enet4 added the bug This is a bug label Feb 23, 2022
@Enet4 Enet4 merged commit 5baac4a into master Feb 23, 2022
@Enet4 Enet4 deleted the bug/encoding/text-test branch March 21, 2022 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant