First steps to impl ParameterSpace #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For impl Drop need fix this facebookresearch/faiss#1598 |
Enet4
reviewed
Feb 18, 2021
There was a problem hiding this comment.
Thank you for working on this. It's true that these bindings are a bit behind on the native Faiss versions, because at some point the project changed to use CMake as the building system and the C API is taking longer to be fully integrated with it. CMake building the C API was recently introduced, but (1) it creates a static library by default instead of a shared object library; (2) it still does not build the GPU part of the C API. I could try looking deeper into this, but my resources on these bindings are limited, and so is my knowledge on CMake.
In the meantime, I can propose a few improvements to what was written here.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5