-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
upgrade faiss #7 #8
Conversation
da627ab
to
2edce1a
Compare
2edce1a
to
c2c7293
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, but so far I haven't managed to build the respective Faiss version on my machine (probably a CUDA or GCC mismatch, will continue trying). In the meantime, I took the liberty of reviewing this code in terms of API design.
I prefer the #[repr(C)]
pub struct FaissClusteringIterationStats_H {
_unused: [u8; 0],
}
#[repr(transprent)]
pub struct ClusteringIterStats(FaissClusteringIterationStats)
// got error[E0690]: transparent struct needs exactly one non-zero-sized field, but has 0 Since |
you can review the changes in 843c1a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, those changes are OK! I somehow assumed that FaissClusteringIterationStats
was a record type rather than an opaque type.
This is good to merge. I'll try to throw in a new crate release (0.9.0) within the next few days. Thank you very much!
@Enet4
This is the first basic patch.
some changes
bindgen
add--size_t-is-usize
, since bindgen change the size_t convertion. This leads a minor change of Index trait. seeremove_ids()