feat: reconstruct API #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes the changes from #90, so please merge that one first.
I added support for
Index::reconstructandIndex::reconstruct_nfor reconstructing the original vector from the index. This is useful for my particular use case where I am bringing my own clusterer instead of using FAISS' k-means (which is actually a partitioner, not a clusterer).I have some questions about the design of the code. Here, you defined a macro
impl_native_index!, but then here and here and here and here it looks like you copy pasted the code instead of using the macro. I copy pasted my changes as well, so as to be minimally invasive, but I am wondering, why did you do that?