Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(all-state-emails): Add logic to include all state emails in templates #1106

Merged
merged 9 commits into from
Feb 3, 2025
Merged

fix(all-state-emails): Add logic to include all state emails in templates #1106

merged 9 commits into from
Feb 3, 2025

Conversation

jdinh8124
Copy link
Collaborator

@jdinh8124 jdinh8124 commented Jan 31, 2025 •
edited
Loading

🎫 Linked Ticket

https://jiraent.cms.gov/browse/OY2-31139

Added logic to send emails in templates to the correct email groups

@jdinh8124 jdinh8124 self-assigned this Jan 31, 2025
@jdinh8124 jdinh8124 temporarily deployed to email-state-kibana January 31, 2025 22:28 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 added the type: FIX Submit bug fixes label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 89.12% 4253 / 4772
🔵 Statements 88.54% 4630 / 5229
🔵 Functions 81.77% 1265 / 1547
🔵 Branches 75.13% 2142 / 2851
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/libs/email/content/withdrawPackage/index.tsx 77.77% 37.5% 75% 77.77% 95-114
Generated in workflow #1870 for commit f5e07e7 by the Vitest Coverage Report Action

@jdinh8124 jdinh8124 temporarily deployed to email-state-kibana January 31, 2025 22:37 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to email-state-kibana January 31, 2025 22:57 — with GitHub Actions Inactive
benjaminpaige
benjaminpaige approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - couldnt hurt to add. great!

@jdinh8124 jdinh8124 temporarily deployed to email-state-kibana February 3, 2025 15:45 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 deployed to email-state February 3, 2025 20:12 — with GitHub Actions Active
@jdinh8124 jdinh8124 merged commit 96834d7 into main Feb 3, 2025
13 of 14 checks passed
@jdinh8124 jdinh8124 deleted the email-state branch February 3, 2025 20:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🎉 This PR is included in version 1.5.0-val.121 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rmuntaqim pushed a commit that referenced this pull request Feb 4, 2025
@jdinh8124 @rmuntaqim
fix(all-state-emails): Add logic to include all state emails in templ…
b6b627d 
…ates (#1106)

* add logging

* Update processEmails.ts

* Update processEmails.ts

* Update index.tsx

* Update index.tsx

* Update processEmails.ts

* Update processEmails.ts
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benjaminpaige benjaminpaige benjaminpaige approved these changes

@13bfrancis 13bfrancis Awaiting requested review from 13bfrancis

Assignees

@jdinh8124 jdinh8124

Labels
released on @val type: FIX Submit bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdinh8124 @benjaminpaige