Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a From/To address field in wallet db #109

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Add a From/To address field in wallet db #109

merged 9 commits into from
Feb 27, 2024

Conversation

johanneshahn
Copy link
Member

The new field From/To Address makes it possible to store the sender/receiver address that was used when creating a new transaction, or receiving a transaction in wallet.
This field is stored outside the slate data and is only available in the wallet db for local usage.

Adds a new optional parameter "addr_to" to api function "tx_lock_outputs".
Adds a new optional parameter "addr_from" to internal function "foreign::receive_tx"

@who-biz
Copy link
Contributor

who-biz commented Jan 9, 2024

We spoke about this last week - but for sake of documenting: Holding off on merging/approving this until we can put it behind a show flag like:

epic-wallet txs -show destination

I will start working on this addition.

@who-biz who-biz added enhancement New feature or request in progress Working on it labels Jan 9, 2024
Copy link
Contributor

@who-biz who-biz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Last commit I made resolved a single merge conflict.

For sake of getting this merged in a timely manner, abandoning idea of putting this behind an optional tag for display. We can handle that later.

@who-biz who-biz merged commit a11157c into master Feb 27, 2024
1 check passed
@who-biz who-biz deleted the from-to-address branch February 27, 2024 22:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request in progress Working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants