Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Commit

Permalink
Catching case where we're sanitizing a streamer id that is numeric. U…
Browse files Browse the repository at this point in the history
…pdating docs to remove PreferSFU (SFU is just selected as a streamer now).
  • Loading branch information
mcottontensor committed Oct 30, 2023
1 parent 403fe39 commit 339aa08
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion Frontend/Docs/Settings Panel.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ This page will be updated with new features and commands as they become availabl
| **Browser send offer** | The browser will start the WebRTC handshake instead of the Unreal Engine application. This is an advanced setting for users customising the frontend. Primarily for backwards compatibility for 4.x versions of the engine. |
| **Use microphone** | Will start receiving audio input from your microphone and transmit it to the Unreal Engine. |
| **Start video muted** | Muted audio when the stream starts. |
| **Prefer SFU** | Will attempt to use the Selective Forwarding Unit (SFU), if you have one running. |
| **Is quality controller?** | Makes the encoder of the Pixel Streaming Plugin use the current browser connection to determine the bandwidth available, and therefore the quality of the stream encoding. **See notes below** |
| **Force mono audio** | Force the browser to request mono audio in the SDP. |
| **Force TURN** | Will attempt to connect exclusively via the TURN server. Will not work without an active TURN server. |
Expand Down
3 changes: 2 additions & 1 deletion SignallingWebServer/cirrus.js
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,8 @@ function sanitizeStreamerId(id) {
for (let [streamerId, streamer] of streamers) {
const idMatchRegex = /^(.*?)(\d*)$/;
const [, baseId, postfix] = streamerId.match(idMatchRegex);
if (baseId != id) {
// if the id is numeric then base id will be empty and we need to compare with the postfix
if ((baseId != '' && baseId != id) || (baseId == '' && postfix != id)) {
continue;
}
const numPostfix = Number(postfix);
Expand Down

0 comments on commit 339aa08

Please # to comment.