Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there is no fine granularity when an error occurs. That makes it more relevant to list as many possibilities for the causes as possible. In this patch, one additional cause is added to the ones already presented (no optimization done due to timeout from max_eval_time_mins).
What does this PR do?
Presents one additional cause to the exception that the user may get. It took me some time to understand the error and this may save other people from this work.
Where should the reviewer start?
Review the change to the message.
How should this PR be tested?
No testing needed, just validate the change to the test.
Any background context you want to provide?
It took me many hours of work to figure out why this
RuntimeError
was being raised. Hopefully, others in the same situation can diagnose their situation in less time.What are the relevant issues?
No relevant issues that I am aware of.
Screenshots (if appropriate)
It is not.
Questions:
Do the docs need to be updated?
No, there is no need to do so. However, there is no mention of what happens when the timeouts are reached. The present
RuntimeError
may not be the full story, so I will leave this chore to someone with greater familiarity with the code.Does this PR add new (Python) dependencies?
No additional dependency is added.