Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct display for implicit and macro-expanded variables #646

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

dbukki
Copy link
Collaborator

@dbukki dbukki commented Oct 14, 2023

Implicit local variables in functions are now marked with the Implicit flag (the same way compiler-generated methods are marked).

Class members and local variables expanded from macros now display the correct text (which is always the type + the name) and jump to the location of the macro's expansion.

Fixes #597.

…ly displayed in the info tree (with type+name and the position of expansion).
…raight to the physical location of the variable, we jump to the place of the macro's expansion. This is in line with how most IDEs like VS jump to the definition of such variables.
@mcserep mcserep added Kind: Bug ⚠️ Plugin: C++ Issues related to the parsing and presentation of C++ projects. labels Oct 18, 2023
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 👏 During testing, I found another issue with local variables, but verified that is unrelated to this PR, so I will open a separate ticket for it.

@mcserep mcserep merged commit a34f994 into Ericsson:master Nov 8, 2023
6 checks passed
@dbukki dbukki deleted the local-var-display branch February 22, 2024 07:37
wbqpk3 pushed a commit to wbqpk3/CodeCompass that referenced this pull request Jul 8, 2024
* Implicit variables and variables expanded from macros are now correctly displayed in the info tree (with type+name and the position of expansion).

* Same fix for class members.

* For macro-expanded variables and class members, instead of jumping straight to the physical location of the variable, we jump to the place of the macro's expansion. This is in line with how most IDEs like VS jump to the definition of such variables.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Kind: Bug ⚠️ Plugin: C++ Issues related to the parsing and presentation of C++ projects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local variables are incorrectly listed in info tree
2 participants