Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix accent url #465

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Fix accent url #465

merged 3 commits into from
Jan 11, 2025

Conversation

fpellet
Copy link
Contributor

@fpellet fpellet commented Jan 11, 2025

This fixes a bug and improves urls for SEO.

Currently, if a question has accents in the title, then there are % in the url.
This creates a technical error when an unauthenticated user tries to answer this question.
When he clicks on answer, it asks him to identify himself, then redirects him to the question, but displays an “HTTP Status 400 - Bad Request” error.

I also did the same thing for the profile.

PR Checklist

  • I have read the CONTRIBUTING document.
  • I checked to ensure there aren't other open Pull Requests or issues on the same topic?
  • I have updated the documentation accordingly (if necessary at all).
  • My code follows the code style of this project and does not alter whitespace formatting.
  • My pull request does not introduce features which are already implemented in Scoold Pro.

Large PRs with changes to more than 20 files are strongly discouraged but will be reviewed.

@albogdano albogdano merged commit 6e18436 into Erudika:master Jan 11, 2025
4 checks passed
@albogdano
Copy link
Member

Merci, Florent! I didn't know about that error.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants