Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generate Node: detect rgb attributes and create color primitive attributes #53

Closed
mistafunk opened this issue Dec 13, 2017 · 3 comments
Closed

Generate Node: detect rgb attributes and create color primitive attributes #53

mistafunk opened this issue Dec 13, 2017 · 3 comments
Assignees
@mistafunk
Labels
enhancement underspecified
Milestone
v0.8

Comments

@mistafunk
Copy link
Collaborator

mistafunk commented Dec 13, 2017 •
edited
Loading

e.g. export color.rgb as color[0], color[1], color[2] float attribute
this should avoid any awkward "color_dot_r" parameters in e.g. VEX nodes

note: this is not about how the assign node passes rule attributes to the generate node
@mistafunk mistafunk added this to the v0.8 milestone Dec 13, 2017
@mistafunk mistafunk self-assigned this Dec 14, 2017
@mistafunk
Copy link
Collaborator Author

discussing attribute naming in the sidefx forums:
https://www.sidefx.com/forum/topic/53124/?page=1#post-238794

mistafunk added a commit that referenced this issue Dec 19, 2017
@mistafunk
#53: generate node: convert foo.rgb prim attrs into foo[0]..[3] tuples
acbc084 
makes it easier to use in VEX etc
mistafunk added a commit that referenced this issue Dec 19, 2017
@mistafunk
#53: refactored & optimized attribute conversion
33563eb 
added time measurement tools
@mistafunk
Copy link
Collaborator Author

  • implemented conversion framework from materials/reports to houdini primitive attributes
  • all float attributes which match the pattern "foo.{r,g,b}" will be converted to houdini foo[3] float tuples

mistafunk added a commit that referenced this issue Dec 19, 2017
@mistafunk
Merge pull request #57 from Esri/#53
5df818d 
#53
@mistafunk
Copy link
Collaborator Author

merged to master

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mistafunk mistafunk

Labels
enhancement underspecified
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@mistafunk