Add some extra keywords #4098
Merged
Add some extra keywords #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you document the new placeholders in the various places they are present in the config? |
JRoy
approved these changes
Mar 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR "answers" #3994 and #4096.
Details
Proposed feature:
Just a few extra keywords that should be useful for those wanting more options in text files that use KeywordReplacer. Also adds the long overdue
{NICKNAME}chat format placeholder.The new
User#getFormattedNickname()method might be a bit confusing amongst all of the other nick-related methods without some comments though. I decided to add it because there's currently no straightforward way to get just the user's formatted nickname without other bits like prefix/suffix and OP color etc. tacked on.New tags (KeywordReplacer):
{NICKNAME}- The player's nickname. If the player has no nickname, the username is shown.{PREFIX}- The player's prefix.{SUFFIX}- The player's suffix.{GROUP}- The player's primary group{PLAYTIME}- The player's playtime.New chat placeholder:
{NICKNAME}- The player's nickname. If the player has no nickname, the username is shown.Environments tested:
OS: Windows 10 20H2
Java version: OpenJDK 1.8.0_282