Fix incorrect behaviours in /back #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
approved these changes
Jun 23, 2021
triagonal
added
module: main
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR re-adds the
essentials.back.onteleportpermission check for setting the user's last location during teleports, which was accidentally left out during the async teleport refactor. Without the check, it's not possible to restrict the use of/backto only on death.Additionally, this PR prevents an NPE when accessing a player's
lastLocationbefore it has been set.Reported by
DarkChroma#3333on the MOSS support server.Details
Environments tested:
OS: Windows 10 20H2
Java version:
openjdk version "11.0.10"