Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix two memory leaks on CALLOC/FREE of ec_globals_alloc function, det… #1205

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix two memory leaks on CALLOC/FREE of ec_globals_alloc function, det… #1205

wants to merge 7 commits into from

Conversation

LocutusOfBorg
Copy link
Contributor

…ected by CFLAGS="-g -fsanitize=address"

Fixes: #1201

@LocutusOfBorg LocutusOfBorg mentioned this pull request Nov 25, 2022
Open
@LocutusOfBorg LocutusOfBorg force-pushed the 1201-fix branch 6 times, most recently from b949703 to 827c465 Compare November 26, 2022 10:17
@koeppea
Copy link
Member

koeppea commented Nov 26, 2022

Wow this PR is impressive.

koeppea
koeppea reviewed Nov 26, 2022
View reviewed changes
src/mitm/ec_ip6nd_poison.c Outdated Show resolved Hide resolved
@LocutusOfBorg LocutusOfBorg force-pushed the 1201-fix branch 7 times, most recently from 0cfa3eb to 3f9fcec Compare November 29, 2022 11:14
@LocutusOfBorg
Copy link
Contributor Author

rebased, I think we are good now?

@koeppea
Copy link
Member

koeppea commented Nov 29, 2022

Fine by me.

@LocutusOfBorg LocutusOfBorg mentioned this pull request Nov 30, 2022
Merged
@koeppea
Copy link
Member

koeppea commented Nov 30, 2022

What were your doubts on #1183?

@LocutusOfBorg
Copy link
Contributor Author

I'm not sure we are currently freeing resources, e.g.
sslstrip_create_session does CALLOC of data ident and s

but the SAFE FREE is done only if #defined non linux

@LocutusOfBorg
Copy link
Contributor Author

same for sslwrap.c

@koeppea
Copy link
Member

koeppea commented Jan 7, 2023 •
edited
Loading

@LocutusOfBorg I've commited some more fixes in regard to memory leaks.
There are still 2 more leaks to go in the plugin area, however I'll raise a dedicated pull-request as this will fix an current issue with the dns_spoof plugin and introduce more than minor changes.

From my point of view for this pull-request, I'm done. So feel free to proceed with your changes or merge.

@koeppea koeppea mentioned this pull request Jan 21, 2023
Merged
@koeppea
Copy link
Member

koeppea commented Feb 4, 2023

Is something pending for this PR on your side @LocutusOfBorg ?

@LocutusOfBorg
Copy link
Contributor Author

yes sorry!

@kurogai
Copy link

kurogai commented Aug 16, 2023

Still pending?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@koeppea koeppea koeppea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in ettercap, ec_globals_alloc, src/ec_globals.c
3 participants
@LocutusOfBorg @koeppea @kurogai