Fix PCAP #977
Merged
Fix PCAP #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #974 |
|
Should we include pcap 1.9.1 with ettercap? Or specifically ask for it? |
|
I think with this PR we're fine wither either version. So I see no need to provide it as bundled. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with libpcap version 1.9.1, some changes come in that affect Ettercap:
pcap_lookupdevice()to determine the default interface has become deprecatedPCAP_TIMEOUTto 0 on Linux (used withpcap_open_live()) causes a huge delay between the call ofpcap_loop()and starting to pass packets to the handler functionec_decode(). This has the effect, that the network scan results in a 0 host list because the scan wait's only 1 second until it cancels the capture thread.This PR addresses both issues. Of course, behavior changes on other platforms still need to be confirmed. However this depends on the availability of the new libpcap version on these platforms.