-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(README): Update logo image to assets and implement in README.md #32
Conversation
Reviewer's Guide by SourceryThis pull request updates the Moodle Mate logo in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EvickaStudio - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a vector image format like SVG for the logo to ensure it scales well on different displays.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -1,7 +1,7 @@ | |||
# Moodle Mate | |||
|
|||
<div align="center"> | |||
<img src="assets/logo.svg" alt="Moodle Mate Logo" width="160"> | |||
<img src="assets/moodlematev_gh_preview.png" alt="Moodle Mate Logo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (typo): Possible typo in image filename.
The filename "moodlematev_gh_preview.png" seems to have an extra 'v'. Was this intentional? Should it be "moodlemate_gh_preview.png"?
<img src="assets/moodlematev_gh_preview.png" alt="Moodle Mate Logo"> | |
<img src="assets/moodlemate_gh_preview.png" alt="Moodle Mate Logo"> |
This pull request includes a small change to the
README.md
file. The change updates the image source for the Moodle Mate logo.README.md
: Changed the image source fromassets/logo.svg
toassets/moodlematev_gh_preview.png
for the Moodle Mate logo.Summary by Sourcery
Documentation: