Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

split out compile-time known information for master elements #1350

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rcknaus
Copy link
Contributor

@rcknaus rcknaus commented Jan 27, 2025

Splits out compile-time known information out of the master element, so you can use the isoparametric information directly in gpu kernels if you want.

This was done before in a different and I had a good experience with it. Having the compile-time known information available at compile time simplifies a lot of the data wrangling with the master elements and speeds up the code, at the expense of making the master element-style computations a little more cumbersome.

Implemented for volume-rank SCS and SCV master elements but not face-rank ones. I just want volume for the GCL, so that's the origin of that. I can finish up the face stuff in a bit or as part of this if it's wanted.

@marchdf
Copy link
Contributor

marchdf commented Jan 27, 2025

Nice work! I like the idea of doing them all in one go and keeping things consistent if that's not too much to ask.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants