Draft: update periodic #1361
Draft
Draft: update periodic #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sseraj
reviewed
Mar 18, 2025
| @@ -147,7 +147,8 @@ TiogaSTKIface::register_mesh() | |||
|
|
|||
| auto* nodeVol = | |||
| meta_.get_field(stk::topology::NODE_RANK, "tioga_nodal_volume"); | |||
| stk::mesh::parallel_max(bulk_, {nodeVol}); | |||
| comm::scatter_max(realm_.bulk_data(), {nodeVol}); | |||
There was a problem hiding this comment.
I had to make this change to get it to compile
Suggested change
| comm::scatter_max(realm_.bulk_data(), {nodeVol}); | |
| sierra::nalu::comm::scatter_max(bulk_, {nodeVol}); |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently diffs and needs some correctness testing. But the idea is to glue the
parallel_opandperiodic_optogether, as a periodic replicated node has almost always the same behavior as a shared node -- when you want a parallel sum, you also want a periodic sum.