Show green dot for uncompleted tasks assigned to current user #20808

youssef-lr · 2023-06-15T12:09:51Z

Details

Adds a green dot next to uncompleted tasks in the LHN that are assigned for the current user. The green dot will not appear for the user who created and assigned the tasks. (This might be subject to change, I'm not sure yet if we should only show the green dot to the assignee)

Fixed Issues

$ polish of #18510

Tests

Please checkout this PR in Auth first, compile and sudo service auth restart before testing.

Open 2 accounts separately, use an Incognito window for the 2nd account.
Create a task from Account A and assign it to Account B.
Make sure Account B, the assignee, is able to see the new task in the LHN and that a green dot appears next to it.
Complete the task from Account B and make sure the green dot disappears and the task is pushed down to the bottom.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-15.at.12.45.18.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-15T12:10:26Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.js

grgia

Few initial changes

src/libs/ReportUtils.js

src/libs/SidebarUtils.js

grgia · 2023-06-15T12:26:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Co-authored-by: Georgia Monahan <38015950+grgia@users.noreply.github.com>

src/libs/actions/Task.js

grgia · 2023-06-15T14:05:34Z

src/libs/SidebarUtils.js

+        result.isTaskCompleted = ReportUtils.isTaskCompleted(report);
+        result.isTaskAssignee = ReportUtils.isTaskAssignee(report);


do you think we should add defaults values for these above?

We only grab these if the report is a task, so I think they'll either be true or false.

Hi ✋ Coming from #22149

We are using the managerEmail to check the task assignee and show the green button if it's isTaskAssignee. Still, in the sidebar links selector, we didn't specify the property managerEmail to the Onyx selector function, making the sidebar not re-rendering on the managerEmail change.

src/components/TaskHeader.js

grgia · 2023-06-15T16:03:58Z

working on testing

src/components/TaskHeader.js

src/libs/actions/Task.js

thienlnam

Approving, going to get a C+ reviewer

youssef-lr · 2023-06-15T18:26:56Z

Approving, going to get a C+ reviewer

I'm afraid they won't be able to test the changes from the backend though. So only optimistically.

thienlnam · 2023-06-15T18:27:30Z

Actually, I see this needs the Auth PR changes so nvm I can run through checklist in a bit

thienlnam · 2023-06-15T22:39:50Z

I think there are unrelated bugs with the assignee and accountID. This does work but for some reason it doesn't look like the assignee shows up

Comments were addressed

thienlnam · 2023-06-15T22:44:35Z

Merging so we can get this in before the freeze

OSBotify · 2023-06-15T22:49:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-16T18:50:43Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:18:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2023-10-03T00:18:24Z

src/components/LHNOptionsList/OptionRowLHN.js

+        !hasBrickError &&
+        (optionItem.isUnreadWithMention ||
+            (optionItem.hasOutstandingIOU && !optionItem.isIOUReportOwner) ||
+            (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isTaskCompleted));


We forgot to take into account the task cancelled state. This later caused #27805

Show green dot for uncompleted tasks assigned to current user

f12b390

youssef-lr requested a review from thienlnam June 15, 2023 12:09

youssef-lr requested a review from a team as a code owner June 15, 2023 12:09

youssef-lr self-assigned this Jun 15, 2023

melvin-bot bot requested review from grgia and removed request for a team June 15, 2023 12:10

youssef-lr commented Jun 15, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

grgia previously requested changes Jun 15, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/SidebarUtils.js Outdated Show resolved Hide resolved

youssef-lr and others added 3 commits June 15, 2023 13:52

Apply suggestions from code review

4f22290

Co-authored-by: Georgia Monahan <38015950+grgia@users.noreply.github.com>

Add JSDocs

0421d53

Merge branch 'main' into youssef_greenDot_uncompleted_tasks

d09672d

youssef-lr mentioned this pull request Jun 15, 2023

[$1000] Not able to add a task assignee #20807

Closed

6 tasks

youssef-lr added 2 commits June 15, 2023 14:26

Fix bug when assigning tasks

44db560

Prettier

7cef0a7

grgia reviewed Jun 15, 2023

View reviewed changes

src/libs/actions/Task.js Show resolved Hide resolved

Use the new isTaskCompleted

90f06a0

grgia reviewed Jun 15, 2023

View reviewed changes

Fix assignee not displayed in task header

76de934

youssef-lr commented Jun 15, 2023

View reviewed changes

src/components/TaskHeader.js Show resolved Hide resolved

Cleanup

ddb17f8

Make check more reliable

31594b7

youssef-lr commented Jun 15, 2023

View reviewed changes

src/components/TaskHeader.js Outdated Show resolved Hide resolved

situchan mentioned this pull request Jun 15, 2023

[HOLD for payment 2023-06-29] [$1000] Console error when selecting a user to assign a task to #19772

Closed

6 tasks

Fix bug when trying to edit a task and assign it to self

5597e7f

youssef-lr force-pushed the youssef_greenDot_uncompleted_tasks branch from c6128c8 to 5597e7f Compare June 15, 2023 17:18

thienlnam requested changes Jun 15, 2023

View reviewed changes

src/components/TaskHeader.js Outdated Show resolved Hide resolved

src/libs/actions/Task.js Outdated Show resolved Hide resolved

Make check more reliable

ccd79e8

Fix condition

286c623

thienlnam requested review from a team and removed request for a team June 15, 2023 18:25

thienlnam approved these changes Jun 15, 2023

View reviewed changes

This comment was marked as outdated.

# to view

melvin-bot bot requested a review from techievivek June 15, 2023 18:25

thienlnam removed the request for review from techievivek June 15, 2023 18:26

thienlnam merged commit d920d19 into main Jun 15, 2023

thienlnam deleted the youssef_greenDot_uncompleted_tasks branch June 15, 2023 22:44

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

mollfpr mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-07-26] [$1000] Green dot doesn't appear automatically when assigning task to self repeatedly #22149

Closed

6 tasks

allroundexperts reviewed Oct 3, 2023

View reviewed changes

allroundexperts mentioned this pull request Oct 3, 2023

[HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted #27805

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show green dot for uncompleted tasks assigned to current user #20808

Show green dot for uncompleted tasks assigned to current user #20808

youssef-lr commented Jun 15, 2023 •

edited

Loading

melvin-bot bot commented Jun 15, 2023

grgia left a comment

grgia commented Jun 15, 2023 •

edited by thienlnam

Loading

grgia Jun 15, 2023

youssef-lr Jun 15, 2023

mollfpr Jul 25, 2023

grgia commented Jun 15, 2023

thienlnam left a comment

This comment was marked as outdated.

youssef-lr commented Jun 15, 2023

thienlnam commented Jun 15, 2023

thienlnam commented Jun 15, 2023

thienlnam commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

allroundexperts Oct 3, 2023

		result.isTaskCompleted = ReportUtils.isTaskCompleted(report);
		result.isTaskAssignee = ReportUtils.isTaskAssignee(report);

Show green dot for uncompleted tasks assigned to current user #20808

Show green dot for uncompleted tasks assigned to current user #20808

Conversation

youssef-lr commented Jun 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 15, 2023

grgia left a comment

Choose a reason for hiding this comment

grgia commented Jun 15, 2023 • edited by thienlnam Loading

Reviewer Checklist

Screenshots/Videos

grgia Jun 15, 2023

Choose a reason for hiding this comment

youssef-lr Jun 15, 2023

Choose a reason for hiding this comment

mollfpr Jul 25, 2023

Choose a reason for hiding this comment

grgia commented Jun 15, 2023

thienlnam left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

youssef-lr commented Jun 15, 2023

thienlnam commented Jun 15, 2023

thienlnam commented Jun 15, 2023

thienlnam commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

allroundexperts Oct 3, 2023

Choose a reason for hiding this comment

youssef-lr commented Jun 15, 2023 •

edited

Loading

grgia commented Jun 15, 2023 •

edited by thienlnam

Loading