-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add merchant and date fields to manual requests #23648
Merged
Beamanator
merged 22 commits into
Expensify:main
from
lukemorawski:lukemorawski-23245-add_merchant_and_date_fields_to_manual_requests
Aug 3, 2023
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
53bc97e
ui and first data flow attemps
lukemorawski dfeadb9
added date and fixed layout
lukemorawski 79612cf
linting
lukemorawski 79b2b56
remove jsconfig
lukemorawski 6d55c8a
fixed missing iou date on native
lukemorawski 12cb636
show more button hidden when details showed
lukemorawski 4cbf319
Merge branch 'main' into lukemorawski-23245-add_merchant_and_date_fie…
lukemorawski e35f9c8
removed button show less state
lukemorawski 696e881
show more button icon fill change
lukemorawski 2844a13
localizing and disabling fields, removing show less
lukemorawski 4642d36
formatting
lukemorawski 9aa9b18
formatting
lukemorawski a59d121
added spanish merchant localization
lukemorawski 8fc5ffe
comment disabled options
lukemorawski 33bf29d
comment
lukemorawski e993ea3
linting
lukemorawski 58806ef
removed merchant from optimistic update
lukemorawski 2eb890f
Merge branch 'main' into lukemorawski-23245-add_merchant_and_date_fie…
lukemorawski 8e49daa
merge fix and formatting
lukemorawski 773bef6
removed unnecessary useeffect dependency
lukemorawski 7f8a634
capitalized merchant in Spanish
lukemorawski b97423b
Merge branch 'main' into lukemorawski-23245-add_merchant_and_date_fie…
lukemorawski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import React, {useCallback, useEffect, useRef, useMemo} from 'react'; | ||
import React, {useCallback, useEffect, useMemo, useRef} from 'react'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same ^ |
||
import {View} from 'react-native'; | ||
import PropTypes from 'prop-types'; | ||
import {withOnyx} from 'react-native-onyx'; | ||
|
@@ -219,6 +219,9 @@ function MoneyRequestConfirmPage(props) { | |
canModifyParticipants={!_.isEmpty(reportID.current)} | ||
policyID={props.report.policyID} | ||
bankAccountRoute={ReportUtils.getBankAccountRoute(props.report)} | ||
iouMerchant={props.iou.merchant} | ||
iouModifiedMerchant={props.iou.modifiedMerchant} | ||
iouDate={props.iou.date} | ||
/> | ||
</View> | ||
)} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,6 +113,10 @@ export default { | |
marginLeft: 'auto', | ||
}, | ||
|
||
ml0: { | ||
marginLeft: 0, | ||
}, | ||
|
||
ml1: { | ||
marginLeft: 4, | ||
}, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
useState
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach as it exposes a bool flag and a toggle function in one line. With
useState
you have declare a separate function to toggle the flag. Nice and clean.