-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
make workspace message scrollable #6695
make workspace message scrollable #6695
Conversation
Looks like the label and Value gap is little much on IOS. Could you please look into that? |
@parasharrajat, Looking into that problem.. but it's not a regression from this pr as even with
Added the videos. |
Thanks for the videos @thesahindia. Ok, I have found the reason why height:100% was added here. When the input is auto-filled, it is used to cover the whole area including the border. Thus highlighted border was getting hidden. Could you please test it and show me a clip/screenshot of that working fine? |
@parasharrajat, It's working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your patience.
cc: @chiragsalian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @chiragsalian in version: 1.1.20-3 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Details
Made the message box scrollable
Made the box fit atleast 3 lines comfortably.
Fixed Issues
$ #6594
Tests
QA Steps
Tested On
Screenshots
Web
web.mp4
Mobile Web
mobile.web.mp4
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4