Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make workspace message scrollable #6695

Merged
merged 1 commit into from
Dec 13, 2021
Merged

make workspace message scrollable #6695

merged 1 commit into from
Dec 13, 2021

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Dec 10, 2021

Details

Made the message box scrollable
Made the box fit atleast 3 lines comfortably.

Fixed Issues

$ #6594

Tests

QA Steps

  1. Go to any Workspace
  2. Go to Manage members
  3. Tap invite member
  4. Add text in "add a personal message" box
  5. Scroll inside message box

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mp4

Mobile Web

mobile.web.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

@thesahindia thesahindia requested a review from a team as a code owner December 10, 2021 07:37
@MelvinBot MelvinBot requested review from chiragsalian and parasharrajat and removed request for a team December 10, 2021 07:37
@parasharrajat
Copy link
Member

Looks like the label and Value gap is little much on IOS. Could you please look into that?
Also, I am expecting to see a video testing of various pages for each platform to make sure there are no regressions. I am not able to remember why height:100% was added. Thanks

@thesahindia
Copy link
Member Author

thesahindia commented Dec 10, 2021

Looks like the label and Value gap is little much on IOS. Could you please look into that?

@parasharrajat, Looking into that problem.. but it's not a regression from this pr as even with height:100% it's still the same.

-> without any changes
Screenshot 2021-12-10 at 4 08 13 PM

Also, will add the testing videos of remaining platforms soon.

Added the videos.

@parasharrajat
Copy link
Member

parasharrajat commented Dec 12, 2021

Thanks for the videos @thesahindia. Ok, I have found the reason why height:100% was added here. When the input is auto-filled, it is used to cover the whole area including the border. Thus highlighted border was getting hidden. Could you please test it and show me a clip/screenshot of that working fine?

@thesahindia
Copy link
Member Author

@parasharrajat, It's working fine.
Here's a screenshot -
Screenshot 2021-12-12 at 9 17 52 PM

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your patience.

cc: @chiragsalian

Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 471566c into Expensify:main Dec 13, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.20-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants