Fix app crashes tapping the room name in the chat #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
38 tasks
mountiny
approved these changes
Dec 13, 2021
marcaaron
approved these changes
Dec 13, 2021
| @@ -91,7 +91,7 @@ const ReportParticipantsPage = (props) => { | |||
| styles.containerWithSpaceBetween, | |||
| ]} | |||
| > | |||
| {participants.length | |||
| {Boolean(participants.length) | |||
There was a problem hiding this comment.
NAB, I usually prefer to compare length like participants.length > 0 since that is a more explicit "boolean" version of checking the length of a string - but this works too.
There was a problem hiding this comment.
👍 I'll keep that in mind for next time.
|
Self-merging with approval. |
OSBotify
pushed a commit
that referenced
this pull request
Dec 13, 2021
Fix app crashes tapping the room name in the chat (cherry picked from commit a294333)
This was referenced Dec 13, 2021
|
🚀 Deployed to staging by @luacmartins in version: 1.1.20-3 🚀
|
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Prevents text from rendering inside a
Viewby usingBoolean(). AddingCP Staginglabel as it fixes a deploy blocker.Fixed Issues
$ #6740
Tests
+button andSelect New RoomQA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
ios.mov
Android
android.mov