Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

List ESLint and plugins as peerDependencies + use babel-eslint parser #8

Closed
wants to merge 5 commits into from
Closed

List ESLint and plugins as peerDependencies + use babel-eslint parser #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba82967
Add ESLint and plugins as peerDependencies
fnwbr Apr 9, 2019
af36a05
Bump version to 2.0.1
fnwbr Apr 9, 2019
790ccdc
Use babel-eslint as our parser
fnwbr Apr 9, 2019
92b0d2c
List correct devDependencies
fnwbr Apr 9, 2019
9f24dfa
Bump version to 2.0.2
fnwbr Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
extends: './index.js'
}
extends: './legacy.js'
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is saying: When linting this repository (eslint-config-expensify) we lint it with the ruleset of the "legacy" rules. And since we only write plain vanilla JavaScript, I figured that's alright. We don't need plugins like eslint-plugin-react or eslint-plugin-jsx-a11y here.

9 changes: 1 addition & 8 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,5 @@ module.exports = {
jquery: true,
node: true
},
parserOptions: {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
generators: true,
objectLiteralDuplicateProperties: true
}
}
parser: 'babel-eslint'
};
12 changes: 9 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
{
"name": "eslint-config-expensify",
"version": "2.0.0",
"version": "2.0.2",
"description": "Expensify's ESLint configuration following our style guide",
"main": "index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/Expensify/eslint-config-expensify.git"
},
"dependencies": {
"eslint": "5.16.0",
"eslint-config-airbnb": "17.1.0",
"eslint-config-airbnb-base": "13.1.0",
"eslint-config-airbnb-base": "13.1.0"
},
"devDependencies": {
"eslint": "5.16.0"
},
"peerDependencies": {
"babel-eslint": "10.0.1",
"eslint": "5.16.0",
"eslint-plugin-import": "2.16.0",
"eslint-plugin-jsx-a11y": "6.2.0",
"eslint-plugin-react": "7.12.4"
Expand Down