Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable save in forms that support Org Unit selection #94

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

MatiasArriola
Copy link
Contributor

@MatiasArriola MatiasArriola commented Feb 19, 2025

📌 References

📝 Implementation

  • Changed shouldDisableSave from state to a memoized value since it's computed
  • Added condition to return true if no OrgUnit is selected for formType === "PrevalenceFacilityLevelForm"

UPDATE: applied the disable condition to all forms that support org unit selection. For that, extracted to a var SURVEYS_WITH_ORG_UNIT_SELECTOR.

📹 Screenshots/Screen capture

2025-02-19.14-00-06.mp4

@ifoche
Copy link
Member

ifoche commented Feb 19, 2025

Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatiasArriola MatiasArriola changed the title Disable save in PrevalenceFacilityLevelForm Disable save in forms that support Org Unit selection Feb 20, 2025
@MiquelAdell MiquelAdell merged commit 5241144 into development Feb 25, 2025
1 check passed
@MiquelAdell MiquelAdell deleted the fix/prevalence-facility-disable-save branch February 25, 2025 10:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants