Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use country code in PPS breadcrumbs #95

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

MatiasArriola
Copy link
Contributor

📌 References

📝 Implementation

  • Add fetch of OrgUnit code
  • Changes required to pass around the value
  • In useSurveyListActions, changed the call to changeCurrentCountryQuestionnaire to set the orgUnit.code instead of survey.name

📹 Screenshots/Screen capture

image

@ifoche
Copy link
Member

ifoche commented Feb 21, 2025

Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatiasArriola in https://github.com/EyeSeeTea/amr-surveys/blob/52411440c5b95a695cdd345cf7734ed94b3b5a31/src/webapp/contexts/current-surveys-context.ts#L12C5-L12C32 and

the type OrgUnitNamedRef gives the impression that we have the survey id, survey name and survey orgUnitid. I understand we never use the survey name anywhere and we just need survey org unit code? then maybe we can rename the OrgUnitNamedRef type to have more meaningful name?

@MatiasArriola
Copy link
Contributor Author

Good catch @9sneha-n!
I've created a new type for the currentCountryQuestionnaire so it's clear that we are storing the orgUnitCode there.

Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelAdell MiquelAdell merged commit 65a656e into development Feb 27, 2025
1 check passed
@MiquelAdell MiquelAdell deleted the fix/breadcrumb-country-code branch February 27, 2025 07:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants