feat: remove user from project 🙅 #1349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
luke-mcfarlane-rocketlab
requested review from
PeterBaker0,
stevecassidy and
ranisa-gupta16
ranisa-gupta16
requested changes
Mar 5, 2025
|
|
||
| const user = await getUserFromEmailOrUsername(req.params.user_id); | ||
|
|
||
| if (!user) { |
There was a problem hiding this comment.
if user is not found, can we return a 404 response instead of internal server error?
| <Button | ||
| variant="destructive" | ||
| className="w-full" | ||
| onClick={async () => { |
There was a problem hiding this comment.
add a try-catch block please to handle any errors.
| } | ||
| ); | ||
|
|
||
| if (!response.ok) return; |
There was a problem hiding this comment.
also we can throw an error like Failed to remove user by displaying the appropriate message for the user.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
BSS-666
Description
Added the ability to remove users from a project.
Proposed Changes
How to Test
Additional Information
I have made it so that you cannot remove admins from surveys for now.
Checklist